added post_install in setup.py file #3883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badGarnet
reviewed
Jan 23, 2025
christinestraub
requested review from
badGarnet,
ryannikolaidis,
tbs17 and
ajjimeno
cragwolfe
approved these changes
Jan 24, 2025
cragwolfe
reviewed
Jan 24, 2025
| - **Correctly patch pdfminer to avoid PDF repair**. The patch applied to pdfminer's parser caused it to occasionally split tokens in content streams, throwing `PDFSyntaxError`. Repairing these PDFs sometimes failed (since they were not actually invalid) resulting in unnecessary OCR fallback. | ||
|
|
||
|
|
badGarnet
reviewed
Jan 25, 2025
| @@ -32,6 +27,30 @@ def check_for_nltk_package(package_name: str, package_category: str) -> bool: | |||
| return False | |||
|
|
|||
|
|
|||
| # We cache this because we do not want to attempt | |||
| # downloading the packages multiple times | |||
| @lru_cache() | |||
There was a problem hiding this comment.
Based on the logic below we don't need cache. Further more (this is kind of pathological edge case but...) caching means we could ignore situations where between checks the nltk data is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auto-download for NLTK for Python Enviroment When user install python library without image, It will automatically download nltk data.
Added
entry_pointsinsetupinsetup.py